Update default LR scheduler to cosine with 0.5 cycles #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mryab
reviewed
Jun 9, 2025
Member
mryab
left a comment
mryab
left a comment
There was a problem hiding this comment.
Can you also bump the version in https://github.com/togethercomputer/together-python/blob/main/pyproject.toml#L15 to 1.5.11, please?
artek0chumak
approved these changes
Jun 9, 2025
- Change default lr_scheduler_type from 'linear' to 'cosine' in finetune.py - Update CLI default to use cosine scheduler - Maintains backward compatibility for explicit scheduler specification
sbassam
force-pushed
the
update-default-lr-scheduler
branch
from
f8a3fa5 to
5194fd4
Compare
mryab
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the requested change outlined in ENG-29703.